On Tue, 19 Mar 2024 19:06:36 GMT, Yudi Zheng <yzh...@openjdk.org> wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
> commit since the last revision:
>
> address comment.
src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 3559:
> 3557: Register tmp5, Register tmp6,
> Register product_hi, Register tmp8) {
> 3558:
> 3559: assert_different_registers(x, xlen, y, ylen, z, tmp1, tmp2, tmp3,
> tmp4, tmp5, tmp6, tmp8);
Suggestion:
assert_different_registers(x, xlen, y, ylen, z, tmp1, tmp2, tmp3, tmp4, tmp5,
tmp6, tmp8, product_hi);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18226#discussion_r1530980566
