On Tue, 19 Mar 2024 19:06:36 GMT, Yudi Zheng <yzh...@openjdk.org> wrote:

>> Moving array construction within BigInteger.implMultiplyToLen intrinsic 
>> candidate to its caller simplifies the intrinsic implementation in JIT 
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   address comment.

src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4670:

> 4668:     const Register tmp6  = r15;
> 4669:     const Register tmp7  = r16;
> 4670:     const Register tmp8  = r17;

It looks like tmp8 is never used.  The call to multiply_to_len() below needs to 
be adjusted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18226#discussion_r1530986811

Reply via email to