On Thu, 4 Apr 2024 11:43:07 GMT, Thiago Henrique Hüpner <d...@openjdk.org> wrote:
> Should the pull request incorporate a modification to the JAVASE script file > for JShell, specifically substituting it with `import module java.se`? (right > now the imports are computed, not read from a file) Given we need to keep the existing code (as `import module java.se` would only work when preview is enabled), and given the outcomes for the user should be (I think, at least) the same, it does not seem necessary to me to complicate things by having two ways to achieve the same outcome. When the feature goes final, then maybe we could consider replacing the hardcoded JAVASE with a script. But, even then, the user might use `-C--release=21`, and `import module java.se` would not work then, so it may be easier to keep the current code even then. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18614#issuecomment-2036957025
