On Tue, 16 Apr 2024 17:09:04 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which is a large spec reformatting for >> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat >> and CompactNumberFormat. >> >> The motivation for this change was the difficulty of readability for these >> classes. This PR consists of changes such as better separating the text into >> sections with headers, advising to skip the pattern related sections if not >> needed, and general wording improvements. >> >> To help with reviewing I have attached a >> [specdiff](https://cr.openjdk.org/~jlu/JDK-8329222/java.base/java/text/package-summary.html) >> as well as the built docs: >> [nFmt](https://cr.openjdk.org/~jlu/api/java.base/java/text/NumberFormat.html), >> >> [dFmt](https://cr.openjdk.org/~jlu/api/java.base/java/text/DecimalFormat.html), >> and >> [cnFmt](https://cr.openjdk.org/~jlu/api/java.base/java/text/CompactNumberFormat.html); >> >> I will update the CSR once the wording is finalized. > > Justin Lu has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains five commits: > > - merge master and add setStrict() to nFmt class spec > - implement suggestions from dFmt review > - implement suggestions from cnFmt review > - implement suggestions from nFmt review > - init src/java.base/share/classes/java/text/NumberFormat.java line 115: > 113: * attributes or key/type pairs. > 114: * <p>Below is an example of a "US" locale currency format with > accounting style, > 115: * <blockquote>{@code > NumberFormat.getInstance(Locale.forLanguageTag("en-US-u-cf-account"));}</blockquote> I replaced the previous Thai digits example with an account currency format style, as it is probably a more common use case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18731#discussion_r1567697780
