On Wed, 17 Apr 2024 17:16:55 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which is a large spec reformatting for >> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat >> and CompactNumberFormat. >> >> The motivation for this change was the difficulty of readability for these >> classes. This PR consists of changes such as better separating the text into >> sections with headers, advising to skip the pattern related sections if not >> needed, and general wording improvements. >> >> To help with reviewing I have attached a >> [specdiff](https://cr.openjdk.org/~jlu/JDK-8329222/java.base/java/text/package-summary.html) >> as well as the built docs: >> [nFmt](https://cr.openjdk.org/~jlu/api/java.base/java/text/NumberFormat.html), >> >> [dFmt](https://cr.openjdk.org/~jlu/api/java.base/java/text/DecimalFormat.html), >> and >> [cnFmt](https://cr.openjdk.org/~jlu/api/java.base/java/text/CompactNumberFormat.html); >> >> I will update the CSR once the wording is finalized. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Make apparent the distinction of cnFmt and dFmt for factory methods. > Loosen wording from cast to convert. LGTM ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18731#pullrequestreview-2007009092
