Hi Carsten,

On May/11/2020, Carles Pina i Estany wrote:

> > To generic variable names are always problematic at some point, so your
> > suggestion to prefix all the DEBUG name is a thing that need to happen.
> > Would you be willing came up with a patch? If not I will try to work on this
> > later within the preparation for next ESR cycle in Debian.
> 
> I'm happy to provide a patch (probably today later or tomorrow evening).
> I didn't in case that someone else was working on it / something else.

I created a salsa.debian.org account and:

a) I was looking at the code and realised that some variables were
initialized to 0 probably for the same reason that the bug was found.
Initially I've done an unset, consistent with existing code: 
https://salsa.debian.org/carlespina/thunderbird/-/commit/eb0d71b9cdb386cd94dea9bd8acabd2374f13a97
 . If you prefer me prefixing that in TB_ or THUNDERBIRD_ let me know.

b) I got a bit carried away:
https://salsa.debian.org/carlespina/thunderbird/-/commits/thunderbird-launcher-variables/
with some small refactoring that you might or might not agree / minor
fixes or deleting code for commented out fixes.

I'm happy to change the name of the variables, but well, it was interesting.

Cheers,

-- 
Carles Pina i Estany

Reply via email to