Hello Carsten,
On May/12/2020, Carsten Schoenert wrote: > Hello Carles, > > Am 12.05.20 um 14:39 schrieb Carles Pina i Estany: > > > > Hi, > > > > I've just seen that I in Salsa I forked it out from > > https://salsa.debian.org/nitsch-guest/thunderbird instead of > > https://salsa.debian.org/mozilla-team/thunderbird . I think that the two > > files that I changed are the same, but tonight I could fork from the > > mozilla-team/thunderbird (or prefix the variables/something else if it > > was preferred). > > just add a new remote source pointing to the "real" thunderbird tree on > salsa and rebase against the trees from there. I ended up doing a new fork (long story off-topic here :-) ) My previous code is in the same URL: https://salsa.debian.org/carlespina/thunderbird/-/tree/thunderbird-launcher-variables The smallest patch would be here: https://salsa.debian.org/carlespina/thunderbird/-/tree/unsets-DEBUG-DEBUGGER (unless we went for renaming DEBUG/DEBUGGER to TB_DEBUG/TB_DEBUGGER). > From a quick view ... > The removal of the DEBUGGER stuff isn't something I'd do. The reason behind > that is simple, there is vagrant out there that is doing a better job in > showing the runtime state if you need to debug something. But we never did > added that to the wrapper script, it's not an easy task. So in my eyes the > removal of the these parts isn't desirable. For sure some more comments will > help further looking people. I haven't used vagrant and I don't know how the DEBUGGER variable would be used in vagrant to show the runtime state. Either way, I understand that for ESR it would be good to minimise changes, but me, as a casual reader of the script it seems that DEBUGGER can be 1 only if DEBUG is 1 (by the option -g) making it not-useful...as it is now, of course! (and making the last set of ifs harder to follow). I just got a bit carried away yesterday. I might have missed some code path and obviously future intentions :-) I'm not sure what's the best way to fix the reported bug and/or if the smallest patch is the way to go. I'm happy to make other changes in the branch - my pleasure! Cheers, -- Carles Pina i Estany
