jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061821679
> From memory that change was to align Tomcat's access log configuration with httpd. It may well be that the correct fix here is to correct the documentation. Separately, comparing this PR and the original code I suspect that, if we did want to merge something along these lines, that there would be performance concerns with the current proposal. As a minimum we'd need to see some performance figures for the proposed formatting. The documentation from Tomcat 9 does indicate that there will be consolidation but it indicates that it only affects AccessLogValve, not the ExtendedAccessLogValve (see [this doc](https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Access_Log_Valve) for %T param). I could make the change for it to look closer to what it used to do in Tomcat 9, but I felt this was easier to read and follow while at the same time wouldn't make a huge performance impact but if that'a a concern I could set it to do it this way: ``` buf.append(Long.toString(time / 1000000000)); buf.append('.'); int remains = (int) (time % 1000000000); buf.append(Long.toString(remains / 100000000)); remains = remains % 100000000; buf.append(Long.toString(remains / 10000000)); buf.append(Long.toString(remains % 10000000)); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
