ChristopherSchultz commented on PR #720:
URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063868914
Oh, I'm' sorry I didn't pick-up on the subtleties of your report.
Tomcat 10.1 is documented that the value for `%T` is in (presumably _whole_)
seconds. Tomcat 9 says it's in fractional seconds and that in Tomcat 10 it will
be truncated to whole-seconds. Are you specifically talking about the
ExtendedAccessLogValve's `time-taken` token? If so, you're right, that
documentation did not change yet the underlying implementation did change.
I can see some scope for still supporting all of these. For example, `%T`
can be `%{us}T` to get microseconds (now a synonym for `%D` so why not
introduce a new flavor e.g. `%{fs}T` for "fractional seconds".
IMHO, "fractional seconds" isn't worth the computation power to format it in
the first place, then parse it later back into milliseconds or whatever. I
would recommend changing your tooling to look for an embedded `.` character and
changing behavior to be backward- and forward-compatible by simply using
milliseconds or microseconds, whichever you prefer.
We should update the documentation for `ExtendedAccessLogValve` to make it
clear that `time-taken` has changed along with `%T` to be whole-seconds.
We can continue this conversation to determine what _else_ we might do, such
as continuing to support "fractional seconds" as an output format. The problem
(for you) with supporting fractional-seconds is that it won't work from 10.1.0
- 10.1.23 at least, so you will have a specific set of Tomcat versions that are
supported by your product and tooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
