What would be the definition of minor modification? AGE in general tries to conform to the ideas in Postgres as much as possible. Which means we are constantly calling Postgres functions to do work and at runtime queries will switch between Postgres source code and AGE source code often. When we cannot use a Postgres function but want to emulate similar behavior, we use that function as a template. For example, the Agtype data type that we use is heavily influenced by the JsonB data type in Postgres and the way we transform expressions is very close to Postgres. A function might have the same logical flow to it, but we need to pass in a different data structure, or we might have some special cases that must be handled differently, but otherwise is very similar to something in postgres.
On Sun, Oct 17, 2021 at 2:17 PM Felix Cheung <felixche...@apache.org> wrote: > In such case, the inclusion of the license is required. > > Also, ideally, the 3rd party source code should be retained as separate > source files so we could keep the license header on each file. If they are > code snippet, then it is a bit of a grey area and we should attribute the > source in license (a practice I've seen in other projects) > > See > https://www.apache.org/legal/src-headers.html#3party > https://www.apache.org/legal/resolved.html#category-a > " > 4. Minor modifications/additions to third-party source files should > typically be licensed under the same terms as the rest of the third-party > source for convenience. > > 5. The project's PMC should deal with major modifications/additions to > third-party source files on a case-by-case basis." > > > > > On 2021/10/13 20:44:15 Josh Innis wrote: > > We resigned the files using an @apache.org account. There is source code > > from Postgres in AGE. There are no files but there are some snippets. > > We create value for our clients by connecting the world's data. > > Josh Innis Software Engineer > > Core R&D Team > > *P*: (831)278-0327 > > 3945 Freedom Circle #260, Santa Clara, CA 95054 > > < > > https://www.google.com/maps/place/3945+Freedom+Cir+%23260,+Santa+Clara,+CA+95054/ > > > > bitnine.net > > > > > > On Sun, Oct 10, 2021 at 5:28 PM Felix Cheung <fe...@apache.org> wrote: > > > > > There bundle also applies to the source release. However, if you are > > > certain none of the source code file or snippet is from the Postgres > code > > > base, then, correct, you don’t need to include Postgres license info. > > > > > > You might want to amend the license and notice, and re-sign with a key > with > > > @apache.org address from my comments earlier. > > > > > > I’m not sure if it will be flagged at IPMC, but it is best since you > have > > > changed the disclaimer in this release. > > > > > > > > > On 2021/10/05 16:54:29 Josh Innis wrote: > > > > Hi Felix, > > > > > > > > We do not have any binary code from Postgres. The key phrase I saw > was " > > > > LICENSE and NOTICE need only be modified to accommodate them *only if > > > their > > > > bits are bundled*." The Apache AGE repository does not have any > binary > > > > source files in it. After reading the links you sent, it appears we > do > > > not > > > > have to keep the Postgres license info in NOTICE and LICENSE. > > > > > > > > > > > > On Sun, Oct 3, 2021 at 12:11 PM Felix Cheung <fe...@apache.org> > wrote: > > > > > > > > > Checking this release, not a blocker but a question: > > > > > > > > > > > > > > > - incubating in name > > > > > > > > > > - signature and hash fine > > > > > > > > > > KEYS file - you should try to sign files with @apache.org issuer > email > > > > > > > > > > - DISCLAIMER is fine > > > > > > > > > > - LICENSE and NOTICE > > > > > > > > > > The PostgreSQL license - is it because of code file taken from the > > > project > > > > > (and then is there license header for these files?) > > > > > > > > > > If it is not coming from code file, then is it because of a binary > > > > > dependency? If so, it should be in a separate LICENSE-binary file > like > > > > > https://github.com/apache/iotdb/blob/master/LICENSE-binary > > > > > > > > > > And potentially the license should be separately stored like > > > > > https://github.com/apache/iotdb/tree/master/licenses > > > > > > > > > > more info: > > > > > > https://infra.apache.org/licensing-howto.html#bundled-vs-non-bundled > > > > > > > > > > - No unexpected binary files > > > > > - All source files have ASF headers > > > > > > > > > > > > > > > > > > > > On 2021/09/24 11:34:24 Kevin Ratnasekera wrote: > > > > > > +1 > > > > > > > > > > > > I checked the following. > > > > > > > > > > > > - Incubating in name. > > > > > > > > > > > > - PGP Signatures. > > > > > > > > > > > > - SHA512 Checksums. > > > > > > > > > > > > - DISCLAIMER exists. > > > > > > > > > > > > - LICENSE and NOTICE are fine. > > > > > > > > > > > > - ASF headers on source files. > > > > > > > > > > > > > > > > > > > > > > > > Regards > > > > > > > > > > > > Kevin > > > > > > > > > > > > On Tue, Sep 21, 2021 at 8:52 PM Eya Badal <ey...@apache.org> > wrote: > > > > > > > > > > > > > +1, I checked the follwoing: > > > > > > > > > > > > > > > > > > > > > x] Download links are valid. > > > > > > > [x] Checksums and PGP signatures are valid. > > > > > > > [x] LICENSE, NOTICE and DISCLAIMER files are correct. > > > > > > > [x] All files have license headers if necessary. > > > > > > > > > > > > > > Best, > > > > > > > Eya Badal Abdisho > > > > > > > > > > > > > > On 2021/09/15 16:11:47, Josh Innis <jo...@bitnine.net> wrote: > > > > > > > > Dear Apache Community, > > > > > > > > > > > > > > > > > > > > > > > > Please vote on releasing the following candidate as Apache > AGE > > > > > version > > > > > > > 0.6.0 > > > > > > > > > > > > > > > > > > > > > > > > The vote is open now and until September 18th at 10:30 AM PST > and > > > > > passes > > > > > > > if > > > > > > > > a majority +1 votes are cast, with a minimum of 3 +1 votes. > > > > > > > > > > > > > > > > > > > > > > > > [ ] +1 Release this package as Apache AGE 0.6.0 > > > > > > > > > > > > > > > > [ ] -1 Do not release this package because ... > > > > > > > > > > > > > > > > > > > > > > > > To learn more about Apache AGE, please see > > > http://age.apache.org/ > > > > > > > > > > > > > > > > > > > > > > > > *Functionalities included and addressed in this release:* > > > > > > > > > > > > > > > > - Add VLE SRF (Set Returning Function). > > > > > > > > > > > > > > > > - Fix Vertex, Edge, and Path serialization bug (AGE2-307) > > > > > > > > > > > > > > > > - Fix CREATE passback bug (AGE2-337). > > > > > > > > > > > > > > > > - Fix CREATE transaction block bug (AGE2-345). > > > > > > > > > > > > > > > > - Fix parallel build errors. > > > > > > > > > > > > > > > > - Fix Travis CI compiler warnings. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ***************************************************************** > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *The git tag to be discussed and voted upon:* > > > > > > > > > > > > > > > > https://github.com/apache/incubator-age/releases/tag/v0.6.0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *The git commit hash:* > > > > > > > > > > > > > > > > commit 3681c90da68353507001db89eb429755d34857f7 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *The release files for 0.6.0, can be found at:* > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/age/0.6.0.rc0/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *The signatures, files, etc. can be found at:* > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/age/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *Signatures used for AGE RCs can be found in this file:* > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/age/KEYS > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *The fingerprint of key to sign release artifacts:* > > > > > > > > > > > > > > > > 2245 1CFA 0521 1612 A4EA 9F05 6EF7 BD28 B870 8B05 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > *For information about the contents of this release, see:* > > > > > > > > > > > > > > > > https://github.com/apache/incubator-age/releases/tag/v0.6.0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thank you for your time. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > > > Josh Innis > > > > > > > > We create value for our clients by connecting the world's > data. > > > > > > > > Josh Innis Software Engineer > > > > > > > > Core R&D Team > > > > > > > > *P*: (831)278-0327 > > > > > > > > 3945 Freedom Circle #260, Santa Clara, CA 95054 > > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > https://www.google.com/maps/place/3945+Freedom+Cir+%23260,+Santa+Clara,+CA+95054/ > > > > > > > > > > > > > > > > bitnine.net > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
