This doesn't make sense to me; in unbundling, and providing a modern build system, why are these sources mentioned?
Expat 2.2.x has it's own build schema, any attempt to replace expat's with APR's seems misguided. Happy to stay mostly hands-off the mak/dsp as this legacy tangle that users continue to consume, but the cmake was done to turn windows builds into a conventional solution. The right fix there is to just switch compiling sources for linking to a library, and let that library maintainer do their thing. So +1 to the dsp/mak change, but alternate CMakeFiles.txt feedback to follow... On Tue, Sep 26, 2017 at 10:13 AM, Gregg Smith <g...@gknw.net> wrote: > cmake should be as well. http://svn.apache.org/r1805330 > > > On 9/26/2017 7:12 AM, William A Rowe Jr wrote: >> >> Proceeding with the understanding that mak, and dsp files are OK on -dev, >> thank >> you for the review in your schema, Steffen! >> >> Cheers, >> >> Bill >> >> On Tue, Sep 26, 2017 at 4:00 AM, Steffen <i...@apachelounge.com> wrote: >>> >>> No issues seen with building and running httpd with apr 1.6.3 and >>> apr-util >>> 1.6.1 >>> >>> >>> On Monday 25/09/2017 at 21:34, Steffen wrote: >>> >>> No, used 1.6.2/1.6.0. >>> >>> Tomorrow (already late here) I can try 1.6.3-dev and 1.6.1-dev. >>> >>> >>> Op 25 sep. 2017 om 20:52 heeft William A Rowe Jr <wr...@rowe-clan.net> >>> het >>> volgende geschreven: >>> >>> Hi Steffen, >>> >>> were you testing 1.6.x branches of apr (1.6.3-dev) and apr-util >>> (1.6.1-dev)? >>> Or the last released 1.6.2/1.6.0 flavors? >>> >>> I'm reviewing here to avoid tagging something that won't build, if you >>> had already >>> done so for Windows, it would speed things up here. >>> >>> Cheers, >>> >>> Bill >>> >>> On Mon, Sep 25, 2017 at 12:11 PM, Steffen <i...@apachelounge.com> wrote: >>> On Windows it does not build out of the box. >>> >>> Missing modules/core include for mod_watchdog.h in >>> mod_proxy_balancer.dsp/mak and libhttp.dsp/mak . Did not checked cmake. >>> >>> Steffen >>> >>> On Monday 25/09/2017 at 14:13, Jim Jagielski wrote: >>> >>> The pre-release test tarballs for Apache httpd >>> version 2.4.28 can be found at the usual place: >>> >>> http://httpd.apache.org/dev/dist/ >>> >>> I'm calling a VOTE on releasing these as Apache httpd 2.4.28 GA. >>> >>> [ ] +1: Good to go >>> [ ] +0: meh >>> [ ] -1: Danger Will Robinson. And why. >>> >>> Vote will last the normal 72 hrs. >>> >>> NOTE: The *-deps are only there for convenience. >>> >>> Thx! >>> >>> >>> >>> >
