Regarding 3122. The fix looks good to me, but one test is broken when I merge in the fix to [CALCITE-3138] "RelStructuredTypeFlattener doesn't restructure ROW type fields”.
So, we are holding until I figure with Khai Tran (author of 3122) and Igor Guzenko (author or 3138) out how to combine the two fixes, or if we decide to just disable that test. Follow the discussion here: https://issues.apache.org/jira/browse/CALCITE-3122?focusedCommentId=16916028&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16916028 <https://issues.apache.org/jira/browse/CALCITE-3122?focusedCommentId=16916028&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16916028> Julian > On Aug 26, 2019, at 4:48 AM, Chunwei Lei <chunwei.l...@gmail.com> wrote: > > Thanks for your work, Stamatis. > > As for 1581, I have reviewed it and it looks good to me. So I am +1 for the > change. > > > > Best, > Chunwei > > > On Mon, Aug 26, 2019 at 1:39 PM Stamatis Zampetakis <zabe...@gmail.com> > wrote: > >> I see that Chunwei has reviewed 1581 and he gave a +1 so I suppose it is >> ready to go. >> >> On Mon, Aug 26, 2019, 7:27 AM Julian Hyde <jh...@apache.org> wrote: >> >>> Sounds good. >>> * I am reviewing 3122 and will commit shortly. >>> * I see Danny has asked me to final review 2302. I'll do that tomorrow. >>> * Who owns 1581? >>> >>> Julian >>> >>> On Sun, Aug 25, 2019 at 1:28 PM Stamatis Zampetakis <zabe...@gmail.com> >>> wrote: >>>> >>>> Hello, >>>> >>>> According to the discussion in JIRA the following issues seem to be >> very >>>> close to been resolved: >>>> https://issues.apache.org/jira/browse/CALCITE-1581 >>>> https://issues.apache.org/jira/browse/CALCITE-2302 >>>> https://issues.apache.org/jira/browse/CALCITE-3122 >>>> >>>> I will wait for those to be merged and then I will start the release >>>> process. I would like to kindly ask the reviewers involved to check >> that >>>> there is nothing more left to do. >>>> >>>> I will start moving the remaining issues to 1.22.0. Let me know if >> there >>> is >>>> anything else that we should include in this release. >>>> >>>> Best, >>>> Stamatis >>>> >>>> On Mon, Aug 19, 2019, 11:04 PM Julian Hyde <jh...@apache.org> wrote: >>>> >>>>> +1 >>>>> >>>>> I’ve poked Khai Tran re. 3122 (Pig). >>>>> >>>>>> On Aug 16, 2019, at 11:20 PM, Stamatis Zampetakis < >> zabe...@gmail.com >>>> >>>>> wrote: >>>>>> >>>>>> Hi all, >>>>>> >>>>>> The release is advancing quite well, yet we have 22 issues marked >> for >>>>>> 1.21.0 [1]. >>>>>> >>>>>> From those, the following 5 seem to be the most important: >>>>>> >>>>>> https://issues.apache.org/jira/browse/CALCITE-1581 >>>>>> https://issues.apache.org/jira/browse/CALCITE-2302 >>>>>> https://issues.apache.org/jira/browse/CALCITE-3122 >>>>>> https://issues.apache.org/jira/browse/CALCITE-3224 >>>>>> https://issues.apache.org/jira/browse/CALCITE-3228 >>>>>> >>>>>> I will try to have an RC for the 26th of August so let's try to get >>> them >>>>> in. >>>>>> >>>>>> [1] >>>>>> >>>>> >>> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 >>>>>> >>>>>> On Thu, Aug 1, 2019 at 8:51 AM Danny Chan <yuzhao....@gmail.com> >>> wrote: >>>>>> >>>>>>> Let’s get the CALCITE-2302[1]: the full implicit type cast support >>> into >>>>>>> 1.21 ! >>>>>>> >>>>>>> [1] https://github.com/apache/calcite/pull/706 >>>>>>> >>>>>>> Best, >>>>>>> Danny Chan >>>>>>> 在 2019年7月21日 +0800 PM3:28，Stamatis Zampetakis <zabe...@gmail.com >>>> ，写道： >>>>>>>> Hi all, >>>>>>>> >>>>>>>> Approximately one month has passed from the previous release >>> (Calcite >>>>>>>> 1.20.0) and I was thinking that it would be nice to have the next >>>>> release >>>>>>>> out by the end of August. To do this I think we should try to >> have >>> an >>>>> RC >>>>>>>> around the 20 of August. >>>>>>>> >>>>>>>> The progress towards the next release can be seen in [1]. As you >>> can >>>>>>>> observe we do not have many issues marked for fixing for 1.21.0 >>> but we >>>>> do >>>>>>>> have many pull requests. >>>>>>>> >>>>>>>> I would like to invite committers to go over the existing PRs and >>> for >>>>>>> those >>>>>>>> that we plan to review and finalize in the next month or so set >>> the fix >>>>>>>> version to 1.21.0 adding an appropriate comment. >>>>>>>> >>>>>>>> In term of priorities, I think we should emphasize on finalizing >>> and >>>>>>>> merging PRs that are blocking other open source projects and >>> commercial >>>>>>>> products from upgrading to the latest release. If it is not >> already >>>>> done >>>>>>>> please assign this issues the highest priority (blocker) and set >>> the >>>>> fix >>>>>>>> version to 1.21.0. >>>>>>>> >>>>>>>> Apart from very important issues it makes sense to treat PRs in >>> FIFO >>>>>>> order. >>>>>>>> Contributors who submit a PR early will certainly get discouraged >>> to >>>>>>>> contribute again if we never merge these PRs in time. >>>>>>>> >>>>>>>> Don't hesitate to reply to this thread if the plan above is not >>>>>>> convenient >>>>>>>> for you! >>>>>>>> >>>>>>>> Best, >>>>>>>> Stamatis >>>>>>>> >>>>>>>> [1] >>>>>>>> >>>>>>> >>>>> >>> >> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 >>>>>>> >>>>> >>>>> >>> >>
