I agree with Julian. Changing to Kotlin needs lots of error, but gets a little gain. Besides, It costs much more time to write a test if developers are not familiar with Kotlin. I prefer to use Java as it is now.
Best, Chunwei On Mon, Dec 16, 2019 at 9:02 AM Julian Hyde <jh...@apache.org> wrote: > I don't think we should do this. > > Multi-line strings are a bit unwieldy, but they're not a major > problem. Transitioning our tests to a different language (Kotlin) is a > drastic solution. It requires developers to understand a new language, > and it loses all history from the source files. > > Julian > > On Sun, Dec 15, 2019 at 4:37 AM Vladimir Sitnikov > <sitnikov.vladi...@gmail.com> wrote: > > > > I've filed two PRs to evaluate the impact of the replacement. > > > > $ to _: https://github.com/apache/calcite/pull/1659 > > 203.3sec, 5510 completed, 3 failed, 91 skipped, Gradle Test Run > > :core:test > > > > $ to #: https://github.com/apache/calcite/pull/1660 > > 196.7sec, 5510 completed, 53 failed, 91 skipped, Gradle Test Run > > :core:test > > > > There are test failures, however, both of them are almost ready. > > > > Both $ and _ are valid "Java identifier start" characters, so variable > name > > like _3 is valid. > > If we use # instead of $, then code generator needs to be updated as well > > as it sometimes uses Java variables like $3, and #3 would become invalid. > > > > Any thoughts? > > > > Vladimir >
