Hi Martin, Sorry, I was travelling today. By saying "complicated" I mean cutting a release with Apache standard is not easy. We definitely need to further automate some of the processes here.
But you made a good point. Thank you again for the good suggestion. I have merged your PR for SEDONA-193 and Mo will create 1.3.0-incubating-rc2 tomorrow. Regards, Jia On Tue, Nov 15, 2022 at 2:10 PM Mo Sarwat <mosar...@apache.org> wrote: > Martin, > > That makes sense. We will take your comment into account and generate a new > release candidate accordingly. > > Thanks a lot, > Mo > > On Tue, Nov 15, 2022 at 4:09 AM Martin Andersson < > u.martin.anders...@gmail.com> wrote: > > > I trust the judgement of the maintainers :) > > It looks like the vote passes. > > > > It's a bit concerning that correctness issues aren't treated as blockers. > > Correctness issues are really the worst kind of defect as it could > silently > > corrupt your data. Performance issues and breaking API changes will break > > your pipelines in a very noticeable way without corrupting the data. A > lax > > attitude towards correctness is a red flag for many enterprises. You > won't > > trust your data with software that might corrupt it. > > > > If the release process doesn't allow for fixing defects it needs to be > > fixed. A defect should only be judged by its severity. Not how hard it is > > to cut a new release candidate. Commonly a release branch is created when > > the process is started. Features and bug fixes are merged to main as > usual. > > If there are any blockers fixed on main they are cherry picked from main > to > > the release branch. > > > > Looking forward to Sedona 1.3.0! Great work every one! > > > > //Martin > > > > Den mån 14 nov. 2022 kl 22:51 skrev Jia Yu <ji...@apache.org>: > > > > > Hi Martin, > > > > > > I don't think this is a blocker and we can put it in the next release. > It > > > is kind of complicated to create another release candidate unless there > > is > > > a critical bug or it misses required components for an Apache release. > > > > > > Hope this makes sense :-) > > > > > > Jia > > > > > > On Mon, Nov 14, 2022 at 3:13 AM Martin Andersson < > > > u.martin.anders...@gmail.com> wrote: > > > > > > > Hi all, > > > > > > > > Should SEDONA-193 be considered a blocker for the release? > > > > > > > > It's a correctness issue and a regression from sedona-1.2.1. > > > > > > > > /Martin > > > > > > > > Den mån 14 nov. 2022 kl 03:18 skrev Kengo Seki <sek...@apache.org>: > > > > > > > > > +1 (binding) > > > > > > > > > > I checked: > > > > > * Download links are valid > > > > > * Checksums and PGP signatures are valid > > > > > * DISCLAIMER and NOTICE are included > > > > > * Source code artifacts have correct names matching the current > > release > > > > > * The project can compile from the source code > > > > > > > > > > Kengo Seki <sek...@apache.org> > > > > > > > > > > 2022年11月13日(日) 21:20 若井幸夫 <swa...@apache.org>: > > > > > > > > > > > > +1 > > > > > > > > > > > > I checked: > > > > > > * Download links are valid > > > > > > * Checksums and PGP signatures are valid > > > > > > * DISCLAIMER and NOTICE are included > > > > > > * Source code artifacts have correct names matching the current > > > release > > > > > > * The project can compile from the source code > > > > > > > > > > > > On Sun, Nov 13, 2022 at 11:07 AM Jia Yu <ji...@apache.org> > wrote: > > > > > > > > > > > > > > Hi Felix, > > > > > > > > > > > > > > In terms of licenses, the only problematic dependency in Sedona > > is > > > > the > > > > > DBI > > > > > > > in Sedona R module. However, Yitao has removed this dependency > > from > > > > > Sedona > > > > > > > in this release: > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/commit/54942047b91a4f60f6d6e3128b73f4c9a7342982 > > > > > > > > > > > > > > I think we are all good here. > > > > > > > > > > > > > > Thanks, > > > > > > > Jia > > > > > > > > > > > > > > On Sat, Nov 12, 2022 at 3:17 PM Felix Cheung < > > > > > felixcheun...@hotmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > What’s the thought on R dbplyr dependency? > > > > > > > > ________________________________ > > > > > > > > From: Jia Yu <ji...@apache.org> > > > > > > > > Sent: Saturday, November 12, 2022 12:40:27 PM > > > > > > > > To: dev@sedona.apache.org <dev@sedona.apache.org> > > > > > > > > Subject: Re: [VOTE] Release Apache Sedona > 1.3.0-incubating-rc1 > > > > > > > > > > > > > > > > Dear all, > > > > > > > > > > > > > > > > This release is supposed to be the last release before > > > graduation. > > > > > Please > > > > > > > > make sure you vote +1 with a checklist (see my vote below). > The > > > > > incubator > > > > > > > > PMCs rejected our graduation proposal last time because we > > didn't > > > > > provide > > > > > > > > the checklist for each vote. > > > > > > > > > > > > > > > > Again, checking this release is extremely easy if you use the > > > > > MyBinder > > > > > > > > notebook provided in Mo's email. All you need to do is click > a > > > few > > > > > buttons > > > > > > > > and wait a few minutes. > > > > > > > > > > > > > > > > We really appreciate your help! > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Jia > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > I checked: > > > > > > > > * Download links are valid > > > > > > > > * Checksums and PGP signatures are valid > > > > > > > > * DISCLAIMER and NOTICE are included > > > > > > > > * Source code artifacts have correct names matching the > current > > > > > release > > > > > > > > * The project can compile from the source code > > > > > > > > > > > > > > > > > > > > > > > > On Sat, Nov 12, 2022 at 8:48 AM Mo Sarwat < > mosar...@apache.org > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > This is a call for vote on Apache Sedona > > 1.3.0-incubating-rc1. > > > > > Please > > > > > > > > refer > > > > > > > > > to the changes listed at the bottom of this email. > > > > > > > > > > > > > > > > > > Release notes: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.3.0-incubating-rc1/docs/setup/release-notes.md > > > > > > > > > > > > > > > > > > Build instructions: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.3.0-incubating-rc1/docs/setup/compile.md > > > > > > > > > > > > > > > > > > GitHub tag: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/releases/tag/sedona-1.3.0-incubating-rc1 > > > > > > > > > > > > > > > > > > GPG public key to verify the Release: > > > > > > > > > https://downloads.apache.org/incubator/sedona/KEYS > > > > > > > > > > > > > > > > > > Source code and binaries: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.3.0-incubating-rc1/ > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours or until at > > least 3 > > > > > "+1" PMC > > > > > > > > > votes are cast > > > > > > > > > > > > > > > > > > Instruction for checking items on the checklist: > > > > > > > > > https://sedona.apache.org/community/vote/ > > > > > > > > > > > > > > > > > > We recommend you use this Jupyter notebook on MyBinder to > > > perform > > > > > this > > > > > > > > > task: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://mybinder.org/v2/gh/jiayuasu/sedona-tools/HEAD?labpath=binder%2Fverify-release.ipynb > > > > > > > > > > > > > > > > > > **Please vote accordingly and you must provide your > checklist > > > for > > > > > your > > > > > > > > > vote**. > > > > > > > > > > > > > > > > > > > > > > > > > > > [ ] +1 approve > > > > > > > > > > > > > > > > > > [ ] +0 no opinion > > > > > > > > > > > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > > > > > > > Checklist: > > > > > > > > > > > > > > > > > > [ ] Download links are valid. > > > > > > > > > > > > > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > > > > > > > > > > > > > [ ] DISCLAIMER is included. > > > > > > > > > > > > > > > > > > [ ] Source code artifacts have correct names matching the > > > current > > > > > > > > release. > > > > > > > > > > > > > > > > > > For a detailed checklist please refer to: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > Mo Sarwat > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Hälsningar, > > > > Martin > > > > > > > > > > > > > -- > > Hälsningar, > > Martin > > >
