Thank you Hyukjin! :) I would prefer to cut v3.4.0-rc4 now if there are no objections.
On Fri, Mar 10, 2023 at 7:01 AM Hyukjin Kwon <gurwls...@gmail.com> wrote: > BTW doing another RC isn't a very big deal (compared to what I did before > :-) ) since it's not a canonical release yet. > > On Fri, Mar 10, 2023 at 7:58 AM Hyukjin Kwon <gurwls...@gmail.com> wrote: > >> I guess directly tagging is fine too I guess. >> I don't mind cutting the RC4 right away either if that's what you prefer. >> >> On Fri, Mar 10, 2023 at 7:06 AM Xinrong Meng <xinrong.apa...@gmail.com> >> wrote: >> >>> Hi All, >>> >>> Thank you all for catching that. Unfortunately, the release script >>> failed to push the release tag v3.4.0-rc3 to branch-3.4. Sorry about the >>> issue. >>> >>> Shall we cut v3.4.0-rc4 immediately or wait until March 14th? >>> >>> On Fri, Mar 10, 2023 at 5:34 AM Sean Owen <sro...@gmail.com> wrote: >>> >>>> If the issue were just tags, then you can simply delete the tag and >>>> re-tag the right commit. That doesn't change a commit log. >>>> But is the issue that the relevant commits aren't in branch-3.4? Like I >>>> don't see the usual release commits in >>>> https://github.com/apache/spark/commits/branch-3.4 >>>> Yeah OK that needs a re-do. >>>> >>>> We can still test this release. >>>> It works for me, except that I still get the weird >>>> infinite-compile-loop issue that doesn't seem to be related to Spark. The >>>> Spark Connect parts seem to work. >>>> >>>> On Thu, Mar 9, 2023 at 3:25 PM Dongjoon Hyun <dongjoon.h...@gmail.com> >>>> wrote: >>>> >>>>> No~ We cannot in the AS-IS commit log status because it's screwed >>>>> already as Emil wrote. >>>>> Did you check the branch-3.2 commit log, Sean? >>>>> >>>>> Dongjoon. >>>>> >>>>> >>>>> On Thu, Mar 9, 2023 at 11:42 AM Sean Owen <sro...@gmail.com> wrote: >>>>> >>>>>> We can just push the tags onto the branches as needed right? No need >>>>>> to roll a new release >>>>>> >>>>>> On Thu, Mar 9, 2023, 1:36 PM Dongjoon Hyun <dongjoon.h...@gmail.com> >>>>>> wrote: >>>>>> >>>>>>> Yes, I also confirmed that the v3.4.0-rc3 tag is invalid. >>>>>>> >>>>>>> I guess we need RC4. >>>>>>> >>>>>>> Dongjoon. >>>>>>> >>>>>>> On Thu, Mar 9, 2023 at 7:13 AM Emil Ejbyfeldt >>>>>>> <eejbyfe...@liveintent.com.invalid> wrote: >>>>>>> >>>>>>>> It might being caused by the v3.4.0-rc3 tag not being part of the >>>>>>>> 3.4 >>>>>>>> branch branch-3.4: >>>>>>>> >>>>>>>> $ git log --pretty='format:%d %h' --graph origin/branch-3.4 >>>>>>>> v3.4.0-rc3 >>>>>>>> | head -n 10 >>>>>>>> * (HEAD, origin/branch-3.4) e38e619946 >>>>>>>> * f3e69a1fe2 >>>>>>>> * 74cf1a32b0 >>>>>>>> * 0191a5bde0 >>>>>>>> * afced91348 >>>>>>>> | * (tag: v3.4.0-rc3) b9be9ce15a >>>>>>>> |/ >>>>>>>> * 006e838ede >>>>>>>> * fc29b07a31 >>>>>>>> * 8655dfe66d >>>>>>>> >>>>>>>> >>>>>>>> Best, >>>>>>>> Emil >>>>>>>> >>>>>>>> On 09/03/2023 15:50, yangjie01 wrote: >>>>>>>> > HI, all >>>>>>>> > >>>>>>>> > I can't git check out the tag of v3.4.0-rc3. At the same time, >>>>>>>> there is >>>>>>>> > the following information on the Github page. >>>>>>>> > >>>>>>>> > Does anyone else have the same problem? >>>>>>>> > >>>>>>>> > Yang Jie >>>>>>>> > >>>>>>>> > *发件人**: *Xinrong Meng <xinrong.apa...@gmail.com> >>>>>>>> > *日期**: *2023年3月9日星期四20:05 >>>>>>>> > *收件人**: *dev <dev@spark.apache.org> >>>>>>>> > *主题**: *[VOTE] Release Apache Spark 3.4.0 (RC3) >>>>>>>> > >>>>>>>> > Please vote on releasing the following candidate(RC3) as Apache >>>>>>>> Spark >>>>>>>> > version 3.4.0. >>>>>>>> > >>>>>>>> > The vote is open until 11:59pm Pacific time *March 14th* and >>>>>>>> passes if a >>>>>>>> > majority +1 PMC votes are cast, with a minimum of 3 +1 votes. >>>>>>>> > >>>>>>>> > [ ] +1 Release this package as Apache Spark 3.4.0 >>>>>>>> > [ ] -1 Do not release this package because ... >>>>>>>> > >>>>>>>> > To learn more about Apache Spark, please see >>>>>>>> http://spark.apache.org/ >>>>>>>> > < >>>>>>>> https://mailshield.baidu.com/check?q=eJcUboQ1HRRomPZKEwRzpl69wA8DbI%2fNIiRNsQ%3d%3d >>>>>>>> > >>>>>>>> > >>>>>>>> > The tag to be voted on is *v3.4.0-rc3* (commit >>>>>>>> > b9be9ce15a82b18cca080ee365d308c0820a29a9): >>>>>>>> > https://github.com/apache/spark/tree/v3.4.0-rc3 >>>>>>>> > < >>>>>>>> https://mailshield.baidu.com/check?q=ScnsHLDD3dexVfW9cjs3GovMbG2LLAZqBLq9cA8V%2fTOpCQ1LdeNWoD0%2fy7eVo%2b3de8Rk%2bQ%3d%3d >>>>>>>> > >>>>>>>> > >>>>>>>> > The release files, including signatures, digests, etc. can be >>>>>>>> found at: >>>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v3.4.0-rc3-bin/ >>>>>>>> > < >>>>>>>> https://mailshield.baidu.com/check?q=U%2fLs35p0l%2bUUTclb%2blAPSYb%2bALxMfer1Jc%2b3i965Bjh2CxHpG45RFLW0NqSwMx00Ci3MRMz%2b7mTmcKUIa27Pww%3d%3d >>>>>>>> > >>>>>>>> > >>>>>>>> > Signatures used for Spark RCs can be found in this file: >>>>>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS >>>>>>>> > < >>>>>>>> https://mailshield.baidu.com/check?q=E6fHbSXEWw02TTJBpc3bfA9mi7ea0YiWcNHkm%2fDJxwlaWinGnMdaoO1PahHhgj00vKwcbElpuHA%3d >>>>>>>> > >>>>>>>> > >>>>>>>> > The staging repository for this release can be found at: >>>>>>>> > >>>>>>>> https://repository.apache.org/content/repositories/orgapachespark-1437 >>>>>>>> > < >>>>>>>> https://mailshield.baidu.com/check?q=otrdG4krOioiB1q4MH%2fIEA444B80s7LLO8D2IdosERiNzIymKGZ2D1jV4O0JA9%2fRVfJje3xu6%2b33PB24x0R5V8ArX6BnzcYSkG5cHg%3d%3d >>>>>>>> > >>>>>>>> > >>>>>>>> > The documentation corresponding to this release can be found at: >>>>>>>> > https://dist.apache.org/repos/dist/dev/spark/v3.4.0-rc3-docs/ >>>>>>>> > < >>>>>>>> https://mailshield.baidu.com/check?q=wA4vz1x6jiz0lcn1hQ0AhAiPk3gdFJbs7dSHwusppbgB4ph846QORuIJQzNRr8GzerMucW3FL7ADPE3radzpmm3er3g%3d >>>>>>>> > >>>>>>>> > >>>>>>>> > The list of bug fixes going into 3.4.0 can be found at the >>>>>>>> following URL: >>>>>>>> > https://issues.apache.org/jira/projects/SPARK/versions/12351465 >>>>>>>> > < >>>>>>>> https://mailshield.baidu.com/check?q=hdSxPMAr37WGNHJRNA4Mh1JkSlqjUL%2bM8BgEclwc23ePHCBzkAjvhgnZa0N7SPRWAcgfoLXjX43CxJXmKnDj0LIElJs%3d >>>>>>>> > >>>>>>>> > >>>>>>>> > This release is using the release script of the tag v3.4.0-rc3. >>>>>>>> > >>>>>>>> > >>>>>>>> > FAQ >>>>>>>> > >>>>>>>> > ========================= >>>>>>>> > How can I help test this release? >>>>>>>> > ========================= >>>>>>>> > If you are a Spark user, you can help us test this release by >>>>>>>> taking >>>>>>>> > an existing Spark workload and running on this release candidate, >>>>>>>> then >>>>>>>> > reporting any regressions. >>>>>>>> > >>>>>>>> > If you're working in PySpark you can set up a virtual env and >>>>>>>> install >>>>>>>> > the current RC and see if anything important breaks, in the >>>>>>>> Java/Scala >>>>>>>> > you can add the staging repository to your projects resolvers and >>>>>>>> test >>>>>>>> > with the RC (make sure to clean up the artifact cache >>>>>>>> before/after so >>>>>>>> > you don't end up building with a out of date RC going forward). >>>>>>>> > >>>>>>>> > =========================================== >>>>>>>> > What should happen to JIRA tickets still targeting 3.4.0? >>>>>>>> > =========================================== >>>>>>>> > The current list of open tickets targeted at 3.4.0 can be found >>>>>>>> at: >>>>>>>> > https://issues.apache.org/jira/projects/SPARK >>>>>>>> > < >>>>>>>> https://mailshield.baidu.com/check?q=4UUpJqq41y71Gnuj0qTUYo6hTjqzT7oytN6x%2fvgC5XUtQUC8MfJ77tj7K70O%2f1QMmNoa1A%3d%3d> >>>>>>>> and >>>>>>>> search for "Target Version/s" = 3.4.0 >>>>>>>> > >>>>>>>> > Committers should look at those and triage. Extremely important >>>>>>>> bug >>>>>>>> > fixes, documentation, and API tweaks that impact compatibility >>>>>>>> should >>>>>>>> > be worked on immediately. Everything else please retarget to an >>>>>>>> > appropriate release. >>>>>>>> > >>>>>>>> > ================== >>>>>>>> > But my bug isn't fixed? >>>>>>>> > ================== >>>>>>>> > In order to make timely releases, we will typically not hold the >>>>>>>> > release unless the bug in question is a regression from the >>>>>>>> previous >>>>>>>> > release. That being said, if there is something which is a >>>>>>>> regression >>>>>>>> > that has not been correctly targeted please ping me or a >>>>>>>> committer to >>>>>>>> > help target the issue. >>>>>>>> > >>>>>>>> > Thanks, >>>>>>>> > Xinrong Meng >>>>>>>> > >>>>>>>> >>>>>>>> >>>>>>>> --------------------------------------------------------------------- >>>>>>>> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >>>>>>>> >>>>>>>>
