On 8/8/05, Wendy Smoak <[EMAIL PROTECTED]> wrote:
> Faces is using a formerly deprecated, and now removed, method in
> RequestUtils. This breaks the Maven build, which works against
> struts-core-1.3.0-dev.
>
> Is this the correct fix?
>
Conceptually that fix makes sense in that it solves the compilation
problem ... but I don't believe that struts-faces should inherit a
dependency on 1.3.x. Today it works (runtime) on 1.1 and 1.2, and it
would be pretty pointless to throw away the vast majority of the
potential target market.
I think Struts-Faces (if it's going to be built with Maven :-) needs
its own set of dependencies, independent of whatever Struts Core is
using. That may mean decoupling from the shared "build"
infrastructure that is so handy across Struts Core ... but this
problem is going to get faced by other subcomponents as soon as they
contemplate independent release cycles.
Maybe the Maven mavens can figure out a way to share the build
infrastructure without sharing the dependency information?
Craig
> Thanks,
> Wendy
>
> Index:
> core-library/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
> ===================================================================
> ---
> core-library/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
> (revision 230657)
> +++
> core-library/src/java/org/apache/struts/faces/application/ActionListenerImpl.java
> (working copy)
> @@ -35,6 +35,7 @@
> import org.apache.struts.config.ModuleConfig;
> import org.apache.struts.faces.Constants;
> import org.apache.struts.faces.component.FormComponent;
> +import org.apache.struts.util.ModuleUtils;
> import org.apache.struts.util.RequestUtils;
>
>
> @@ -152,7 +153,7 @@
> // Invoke the appropriate request processor for this request
> try {
> request.setAttribute(Constants.ACTION_EVENT_KEY, event);
> - RequestUtils.selectModule(request, servletContext);
> + ModuleUtils.getInstance().selectModule(request,
> servletContext);
> ModuleConfig moduleConfig = (ModuleConfig)
> request.getAttribute(Globals.MODULE_KEY);
> if (log.isTraceEnabled()) {
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
