+1 iff flake8 can validate f-srings as well as PyCharm does f-strings! I think flake8 would mean that SublimeText and Atom can highlight errors.
Background - Arguments based on readability are so subjective. If I am using Pycharm, f-strings are very readable, and it will check whether a keyword argument is defined, e.g. what about command-line tools? My guess is that validating format and %- strings is an easier problem because context is localized, but maybe not as solved. On Tue, Jul 21, 2020 at 9:53 AM Shai Berger <s...@platonix.com> wrote: > Hi Dave and all, > > On Tue, 21 Jul 2020 13:56:53 +0100 > Dave Vernon <d...@springbourne-tech.com> wrote: > > > More generally: > > > > I understand the value of *not* doing a bulk change in a PR, but I was > > wondering if it's OK to do a PR based purely on improved performance > > for a specific element? (I don't have one in mind, the question is > > purely 'in principle') > > We are still in discussions here, but if I understand the forming > concensus correctly, it will be ok to replace older-style formatting > with f-strings if you're making changes in the code in question, and > performance-improving changes are, in principal, welcome. > > However, whether the performance improvement afforded by such a change > would, on its own, justify the change -- will need to be judged on a > case-by-case basis, and my guess is that justifiable cases will be few > and far between. I believe that in most cases, string formatting is not > a major performance bottleneck. > > My non-shot-calling 2-cents' worth, > > Shai. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/20200721165300.70bd9631.shai%40platonix.com > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFzonYa1hWUYUOw_soGSx%3DykUBDfGw1mspx5qvyNMfk9mbiedQ%40mail.gmail.com.
