On Tue 12/1/2016, at 12:37 am, Michael Witten <mfwit...@gmail.com> wrote: > Well, even if I go through the trouble of interfacing with this > other community (OpenSSH), and thereby successfully introduce > these changes 'upstream', it sounds like there's still going to > be a lot of work to get the result merged 'downstream' as > part of the project that I actually [and, yet, only marginally] > care about (Dropbear SSH). > > This seems like it's going to be a waste of my time, and I've > already spent a not-insignificant amount of time on this. > > My instinct is that we should view Dropbear's copies as being > what they, in fact, are: forks with their own history and > purpose.
I've added a note at the top of the scp files. Even if changes are being stored in a more structured manner they would be best kept minimal - less things to think about. I've pushed a smaller change that should avoid scp requiring valid usernames. I've committed the newline for fatal(). I don't think the change to make cli-main/runopts use get_user_name() is worthwhile - it's easier to reason about program logic if everything is set up at startup rather than lazily evaluated. If it were a case where performance mattered it might be useful, not in this case. Cheers, Matt
