On Sun, 03 Jan 2010 20:10:19 +0000
Matthew Seaman <m.sea...@infracaninophile.co.uk> wrote:

Comments, critique are welcome.  Unless there are any killer bugs,
I'll send-pr(1) in a week or so.

You have:

: ${daily_sa_compile="YES"}

sa-compile is installed by the SA port, but it requires devel/re2c,
which is an optional dependency. With a standard install your script
will update the rules, the compile will unconditionally fail, and so
spamd won't get restarted.

You could detect the re2c port, but I think it would be better to turn
it off by default

I'd also suggest running sa-compile with nice  by default.

I've put up a set of diffs (patches) in shar format that address some of these issues:

1) re2c is listed as a run dependency. No two ways around it - if you do plan on running sa-compile at some time, you'll need re2c, and chances are that the machine that is running sa-update is also going to be running sa-compile.

2) sa-compile is nice(1)'d by default, and you can provide other flags to nice(1) as well.

See http://www.gsicomp.on.ca/~matt/sa-utils-patches.shar

Regards,
--
Matt Emmerton
_______________________________________________
freebsd-questions@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-questions
To unsubscribe, send any mail to "freebsd-questions-unsubscr...@freebsd.org"

Reply via email to