Hi Justin, Thanks you for you feedback, I write some answer to your question :D
Graphchi: Graphchi has an Apache License. The authors didn't mention the license in the repository of graphchi-java(it is a wrapper of Graphchi-cpp). Still, in the graphchi-cpp you can find the license[1]; also, it is possible to see the reference to the licence of graphchi-java in the maven repository [2]. JSON: The class JSONArray [3] and JSONObject [4] have the same name that you can find in [5] and [6] in the project JSON-java [7]. We implemented the wrapper with the same name and signature because of compatible licenses issues and several code dependencies. The wrapper was created not to affect the functionality of the current code but to be enabled to replace the library JSON-java for Jackson[8]. Jackson has an Apache License. PageRank: we created an operator called PageRankOperator [9]; you can see the use of WayangPlans#pageRankWithDictionaryCompression in [10]. However, the PageRank will be converted depending on the optimiser's decision to one of the implementations [11, 12,13, 14]. In the different implementations, we implement the page rank algorithm following the API of the platform, or we use an implementation of the platform. Does this explanation address your question? NOTICE: we include Apache Spark, Apache Flink, Apache Hadoop, Apache Giraph and Graphchi-Java, because they contain dependencies that are transitive to the Wayang code, and when wayang review the dependencies licenses [15], the projects mentioned and their dependencies are excluded [16] Copyright: we will modify them as soon as possible. Best regards, Bertty [1] https://github.com/GraphChi/graphchi-cpp#license [2] https://mvnrepository.com/artifact/org.graphchi/graphchi-java [3] https://github.com/apache/incubator-wayang/blob/main/wayang-commons/wayang-core/src/main/java/org/apache/wayang/core/util/json/JSONArray.java [4] https://github.com/apache/incubator-wayang/blob/main/wayang-commons/wayang-core/src/main/java/org/apache/wayang/core/util/json/JSONObject.java [5] https://github.com/stleary/JSON-java/blob/master/src/main/java/org/json/JSONArray.java [6] https://github.com/stleary/JSON-java/blob/master/src/main/java/org/json/JSONObject.java [7] https://github.com/stleary/JSON-java [8] https://github.com/FasterXML/jackson-core [9] https://github.com/apache/incubator-wayang/blob/main/wayang-commons/wayang-basic/src/main/java/org/apache/wayang/basic/operators/PageRankOperator.java [10] https://github.com/apache/incubator-wayang/blob/main/wayang-tests-integration/code/test/java/org/apache/wayang/tests/WayangPlans.java#L665-L668 [11] https://github.com/apache/incubator-wayang/blob/main/wayang-platforms/wayang-spark/code/main/scala/org/apache/wayang/spark/operators/graph/SparkPageRankOperator.scala [12] https://github.com/apache/incubator-wayang/blob/main/wayang-platforms/wayang-flink/code/main/java/org/apache/wayang/flink/operators/FlinkPageRankOperator.java [13] https://github.com/apache/incubator-wayang/blob/main/wayang-platforms/wayang-giraph/src/main/java/org/apache/wayang/giraph/operators/GiraphPageRankOperator.java [14] https://github.com/apache/incubator-wayang/blob/main/wayang-platforms/wayang-graphchi/src/main/java/org/apache/wayang/graphchi/operators/GraphChiPageRankOperator.java [15] https://github.com/apache/incubator-wayang/blob/main/pom.xml#L1248-L1279 [16] https://github.com/apache/incubator-wayang/blob/main/pom.xml#L1274-L1276 El dom, 24 oct 2021 a las 3:06, Justin Mclean (<jus...@classsoftware.com>) escribió: > Hi, > > -1 (binding) as this release seems to contain 3rd party code incorrectly > labeled as ASF code and contains code of unknown and category X licenses. > But it’s not 100% clear in all cases. You might want to consider using the > work in progress disclaimer while you fix these things. > > I checked: > - incubating in name > - signatures and hashes are fine > - LICENSE seems to be missing 3rd party licensed code. Information about > licenses goes in LICENSE not NOTICE. Looks like this release may include > creative commons licensed code [2][3]? Missing license for this 3rd party > code [4][5]? > - NOTICE seems malformed. I don’t know why it mentions these projects or > why it names them in the way it does. Is any of this software included in > the release? if so where? > - Looks like release may contain code of an unknown license [1] > - Source files have ASF headers. However it look likes some 3rd party code > (graphchi) incorrectly has had ASF headers added? > - Some copyright line are incorrect "Copyright 2020 Apache (incubating) > Wayang Team” and "Copyright 2020, 2021 Apache (incubating) Wayang Team” > - No unexpected binary files > - Can compile from source > > Kind Regards, > Justin > > 1. https://github.com/GraphChi/graphchi-java > 2. https://en.wikipedia.org/wiki/PageRank > 3. > ./wayang-tests-integration/code/test/java/org/apache/wayang/tests/WayangPlans.java > > 4../wayang-commons/wayang-core/src/main/java/org/apache/wayang/core/util/json/JSONArray.java > 5. > ./wayang-commons/wayang-core/src/main/java/org/apache/wayang/core/util/json/JSONObject.java > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
