Hi Maxime,

On Sat, May 14, 2016 at 12:09:07AM +0200, Maxime de Roucy wrote:
> Hello Willy,
> 
> Le vendredi 13 mai 2016 à 19:22 +0200, Willy Tarreau a écrit :
> > Maxime, could you please add a call to setlocale(LC_ALL, "") as
> > suggested by Nenad before starting to scan the directories ? If
> > something isn't 100% clear to you, do not hesitate to ask for more
> > details, you won't look stupid, I did before you :-)
> 
> It's clear.
> I didn't know either that I had to call setlocale to get the locale
> from the environment. I read the man strcoll and thought it would use
> LC_COLLATE (from the environment) without other call.

That's the benefit of posting patches to the list as you can see :-)

> I add the setlocale call in the main function because it doesn't set
> any haproxy variable. But "init" also sound like a good place.
> Let me know if you prefer to move setlocale from main.

Let's leave it there at least we can't miss it if we look for it. It's
easy to move if someone is unhappy with it.

Thanks!
Willy


Reply via email to