On Wed, Sep 16, 2009 at 05:13:41PM +0300, Vasily Khoruzhick wrote: > > Ideally these parameters would get moved to runtime variables that > > default to their current values. That way, one could change the > > locations by just setting some variables in their haret bootup script. > > Here's a patch in attachment to make kernel offset configurable. > One could set OFFSET variable in default.txt to appropriate kernel offset. > For > rx1950 offset is 0x90000
Thanks - see my comments below: > +REG_VAR_INT(0, "OFFSET", kernelOffset, "Kernel text offset delta value") Lets name this something more descriptive - for example "KERNEL_OFFSET". > -// Recommended tags placement = RAM start + 256 > -#define PHYSOFFSET_TAGS 0x100 > -// Recommended kernel placement = RAM start + 32K > -#define PHYSOFFSET_KERNEL 0x8000 > +// Recommended tags placement = RAM start + kernelOffset + 256 > +#define PHYSOFFSET_TAGS (localKernelOffset + 0x100) > +// Recommended kernel placement = RAM start + kernelOffset + 32K > +#define PHYSOFFSET_KERNEL (localKernelOffset + 0x8000) Using a local variable in a macro will lead to confusion - I'd prefer if you explicitly add the variable at all the macro sites. > // Initrd will be put at the address of kernel + 5MB > #define PHYSOFFSET_INITRD (PHYSOFFSET_KERNEL + 0x500000) Wont the initrd also need to be relocated? -Kevin _______________________________________________ Haret mailing list Haret@handhelds.org https://handhelds.org/mailman/listinfo/haret
