Github user lamber-ken commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3017#discussion_r244014071
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
    @@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String 
lockFile) {
             status = true;
           }
         } catch (IOException e) {
    -      status = false;
    +      // status = false;
    --- End diff --
    
    > I suggest we print a warning message, and remove this assignment
    > @ravipesala @QiangCai
    
    ok, I saw some exception just catch, not print message. so I think it's no 
need here before, like 
[HdfsFileLock](https://github.com/apache/carbondata/blob/128a6c8672b2f23f5abc12753755d2c752cc69cb/core/src/main/java/org/apache/carbondata/core/locks/HdfsFileLock.java#L82)
    
    



---

Reply via email to