Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3017#discussion_r244065800
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java ---
@@ -112,7 +112,7 @@ public LocalFileLock(String lockFileLocation, String
lockFile) {
status = true;
}
} catch (IOException e) {
- status = false;
+ // status = false;
--- End diff --
Yes, I think HdfsFileLock has similar problem. Actually there is a PR #2878
trying to fix all exception code style problem, by @kevinjmh . I suggest we can
have it handled in that PR. Then for this PR, I think you can remove the
assignment directly, same for HdfsFileLock
---
