saintstack commented on a change in pull request #1461: HBASE-23779 Up the default fork count to make builds complete faster;… URL: https://github.com/apache/hbase/pull/1461#discussion_r405883519
########## File path: dev-support/hbase-personality.sh ########## @@ -140,7 +140,15 @@ function personality_modules clear_personality_queue - extra="-DHBasePatchProcess" + # Set a fork count based off the host cpu count. Pass maven a -T argument. + # Default -T is one thread. 0.5C on an apache box of 16 cores and 2 jenkins + # 'executors' per host should make for 8 threads. Setting this here for yetus + # to pick up. See + # https://yetus.apache.org/documentation/0.11.1/precommit-advanced/#global-definitions + # See below for more on -T: + # https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3 + forkcount="0.5C" + extra="-T${forkcount} -Dsurefire.firstPartForkCount=${forkcount} -Dsurefire.secondPartForkCount=${forkcount} -DHBasePatchProcess" Review comment: Thanks for the review. bq. How does maven --threads interact with surefire forks? There is no correlation. There may be cases where it acts as a multiplier where modules are independent of each other but generally, there is little opportunity for -T benefit in hbase builds. I went back and checked a few machines. Couldn't find instance where fork count rose above forkcount limit. Doesn't mean it doesn't happen. Let me untangle the two. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
