saintstack commented on a change in pull request #1461: HBASE-23779 Up the default fork count to make builds complete faster;… URL: https://github.com/apache/hbase/pull/1461#discussion_r405942044
########## File path: dev-support/hbase-personality.sh ########## @@ -140,7 +140,15 @@ function personality_modules clear_personality_queue - extra="-DHBasePatchProcess" + # Set a fork count based off the host cpu count. Pass maven a -T argument. + # Default -T is one thread. 0.5C on an apache box of 16 cores and 2 jenkins + # 'executors' per host should make for 8 threads. Setting this here for yetus + # to pick up. See + # https://yetus.apache.org/documentation/0.11.1/precommit-advanced/#global-definitions + # See below for more on -T: + # https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3 + forkcount="0.5C" + extra="-T${forkcount} -Dsurefire.firstPartForkCount=${forkcount} -Dsurefire.secondPartForkCount=${forkcount} -DHBasePatchProcess" Review comment: Hmm... on big box, with 1.0C and no T, build takes 1hr 15mins. With 0.5C and T==2, takes 53minutes. There are probably spurts of lots of processes but interesting that overall time taken goes down significantly. Let me come back and set the T in another follow-on issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
