d-c-manning opened a new pull request #4274: URL: https://github.com/apache/hbase/pull/4274
[HBASE-26718](https://issues.apache.org/jira/browse/HBASE-26718) Of particular note: 1. The tests as they exist today are not validating a rename into archive, but instead validating a rename *from* archive into the timestamped backup copy. With this change, the tests are actually validating the proper renames. 2. I add a short-circuit return for the case where the source file does not exist, as there is no reason to delete a file from archive if we don't even have a source file to move. 3. I retained the logic for sidelining the archived file and moving the source file, if they both exist. One could argue that we could ignore the source file instead... I am really hoping this is the "one in a trillion" case that the comment mentions. So I left the logic as-is, in case it is silently being relied on somewhere, or in case for some reason the archive file truly is detritus. I did upgrade the log from `debug` to `error` as this does not seem like any condition we want to rely on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
