d-c-manning commented on a change in pull request #4274:
URL: https://github.com/apache/hbase/pull/4274#discussion_r834989985
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java
##########
@@ -185,11 +215,30 @@ private void
testArchiveStoreFilesDifferentFileSystems(String walDir, String exp
when(mockedFile.getPath()).thenReturn(filePath);
when(mockedFileSystem.rename(any(),any())).thenReturn(true);
archivingFunction.apply(conf, mockedFileSystem, mockedRegion, tableDir,
family, list);
- ArgumentCaptor<Path> pathCaptor = ArgumentCaptor.forClass(Path.class);
- verify(mockedFileSystem, times(2)).rename(pathCaptor.capture(), any());
Review comment:
note that we used to validate that:
1. we had two rename calls (one to sideline the timestamped backup, and one
to actually do the archive)
2. we only validated the first call - that the source file was in the
archive folder... which is not the important part we want to validate here.
Now we do some improved validations depending on the scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
