[ https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839726 ]
ASF GitHub Bot logged work on HIVE-26809: ----------------------------------------- Author: ASF GitHub Bot Created on: 17/Jan/23 17:46 Start Date: 17/Jan/23 17:46 Worklog Time Spent: 10m Work Description: difin commented on code in PR #3833: URL: https://github.com/apache/hive/pull/3833#discussion_r1072298943 ########## ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java: ########## @@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean isCompressed, PositionProvider i index.getNext(); } - protected static class StringStreamReader extends StringTreeReader + public static class StringDictionaryTreeReaderHive extends TreeReader { Review Comment: Hi @ayushtkn, I agree with you. It is not ideal approach. Before implementing this approach I did try to adapt Hive, but I didn't succeed to find how Hive could be adapted to ORC-1060 changes because those changes are inside internal implementation of Orc StringDictionaryTreeReader class. The API of StringDictionaryTreeReader class remained the same. I agree with you that this approach is not ideal and will backfire in future when we try to upgrade and the changes in ORC depends on the ones which we ditched, but Hive already heavily depends on internal ORC API by implementing its own column readers on top of ORC and when upgrading to different ORC version it is often required to make adaptations in Hive. Issue Time Tracking ------------------- Worklog Id: (was: 839726) Time Spent: 5.5h (was: 5h 20m) > Upgrade ORC to 1.8.1 > -------------------- > > Key: HIVE-26809 > URL: https://issues.apache.org/jira/browse/HIVE-26809 > Project: Hive > Issue Type: Improvement > Affects Versions: 4.0.0 > Reporter: Dmitriy Fingerman > Assignee: Dmitriy Fingerman > Priority: Major > Labels: pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)