chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559398541
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ########## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType; public class OffsetConfig { Review Comment: it seems to me the package `GroupCoordinatorConfig.OffsetConfig` is a bit confused, and move `OffsetConfig` out of `GroupCoordinatorConfig` should be fine. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org