OmniaGM commented on code in PR #15684:
URL: https://github.com/apache/kafka/pull/15684#discussion_r1559529499
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java:
##########
@@ -20,16 +20,51 @@
import org.apache.kafka.common.record.CompressionType;
public class OffsetConfig {
Review Comment:
It is also bit odd to have a class only for the constructor that do nothing
but grouping. But I can see that split it out might be better as it seems like
we have `GroupConfig` in scala that will get migrated to java at some point so
wouldn't make sense to have the `GroupCoordinatorConfig` grow out of hand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
