gaurav-narula commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1569160539
##########
core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java:
##########
@@ -93,7 +93,7 @@ public List<Extension> getAdditionalExtensions() {
TestKitNodes nodes = new TestKitNodes.Builder().
setBootstrapMetadataVersion(clusterConfig.metadataVersion()).
setCombined(isCombined).
- setNumBrokerNodes(clusterConfig.numBrokers()).
+ setNumBrokerNodes(clusterConfig.numBrokers(),
clusterConfig.numDisksPerBroker()).
Review Comment:
```suggestion
setBrokerNodes(clusterConfig.numBrokers(),
clusterConfig.numDisksPerBroker()).
```
##########
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##########
@@ -114,6 +118,25 @@ public void testClusterTests() {
}
}
+ @ClusterTests({
+ @ClusterTest(name = "cluster-tests-1", clusterType = Type.ZK,
disksPerBroker = 1),
+ @ClusterTest(name = "cluster-tests-2", clusterType = Type.KRAFT,
disksPerBroker = 2),
+ @ClusterTest(name = "cluster-tests-3", clusterType = Type.CO_KRAFT,
disksPerBroker = 2)
+ })
+ public void testClusterTestWithDisksPerBroker() throws ExecutionException,
InterruptedException {
+ Admin admin = clusterInstance.createAdminClient();
+
+ DescribeLogDirsResult result =
admin.describeLogDirs(clusterInstance.brokerIds());
+ result.allDescriptions().get().forEach((brokerId,
logDirDescriptionMap) -> {
+ if
(clusterInstance.clusterType().equals(ClusterInstance.ClusterType.ZK)) {
+ Assertions.assertEquals(1, logDirDescriptionMap.size());
+ } else if
(clusterInstance.clusterType().equals(ClusterInstance.ClusterType.RAFT)) {
+ Assertions.assertEquals(2, logDirDescriptionMap.size());
+ } else {
+ Assertions.fail("Unknown cluster type " +
clusterInstance.clusterType());
+ }
+ });
+ }
Review Comment:
Nit: new line after the function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
