chia7712 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1572122943


##########
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##########
@@ -179,8 +186,8 @@ private void processClusterTest(ExtensionContext context, 
ClusterTest annot, Clu
                 throw new IllegalStateException();
         }
 
-        ClusterConfig.Builder builder = ClusterConfig.clusterBuilder(type, 
brokers, controllers, autoStart,
-            annot.securityProtocol(), annot.metadataVersion());
+        ClusterConfig.Builder builder = ClusterConfig.clusterBuilder(type, 
brokers, controllers, disksPerBroker,

Review Comment:
   We can do that in this PR as most changes involved by refactor are in this 
method. Let's do it to decorate our test infrastructure:)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to