linu-shibu commented on PR #15620: URL: https://github.com/apache/kafka/pull/15620#issuecomment-2064470343
> Hi @linu-shibu @showuon this still uses raw types, and so is still type-unsafe. Fixing that was my motivation for creating the ticket, sorry for not emphasizing it more. > > I think it should be addressed in this PR rather than a follow-up, because it involves changes to the exact same code. > > One other thought that occurs to me now is that we should store the metadata transform instances, so that we don't incur the cost of constructing them for each call. > > Thanks! Sure @gharris1727, I will address the above mentioned comments and update the PR. Thanks for pointing it out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
