gharris1727 commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1573855150
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##########
@@ -46,69 +44,65 @@ public class RemoteLogMetadataSerde {
private static final short REMOTE_PARTITION_DELETE_API_KEY = new
RemotePartitionDeleteMetadataRecord().apiKey();
private static final short REMOTE_LOG_SEGMENT_METADATA_SNAPSHOT_API_KEY =
new RemoteLogSegmentMetadataSnapshotRecord().apiKey();
- private final Map<String, Short> remoteLogStorageClassToApiKey;
- private final Map<Short, RemoteLogMetadataTransform> keyToTransform;
private final BytesApiMessageSerde bytesApiMessageSerde;
+ private ApiMessageAndVersion apiMessageAndVersion;
+
+ private final RemoteLogSegmentMetadataTransform
remoteLogSegmentMetadataTransform;
Review Comment:
This looks pretty verbose, can you shorten the variable names? We're already
in the `RemoteLogMetadataSerde`, so `remoteLog` and `Metadata` end up being
visual clutter.
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##########
@@ -46,69 +44,65 @@ public class RemoteLogMetadataSerde {
private static final short REMOTE_PARTITION_DELETE_API_KEY = new
RemotePartitionDeleteMetadataRecord().apiKey();
private static final short REMOTE_LOG_SEGMENT_METADATA_SNAPSHOT_API_KEY =
new RemoteLogSegmentMetadataSnapshotRecord().apiKey();
- private final Map<String, Short> remoteLogStorageClassToApiKey;
- private final Map<Short, RemoteLogMetadataTransform> keyToTransform;
private final BytesApiMessageSerde bytesApiMessageSerde;
+ private ApiMessageAndVersion apiMessageAndVersion;
Review Comment:
This shouldn't be an instance variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
