OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576354443
##########
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##########
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
users.get.filterNot(usersToSkip.contains).foreach { user =>
try {
val userConfigs = adminZkClient.fetchEntityConfig(ConfigType.USER,
Sanitizer.sanitize(user))
- addToResultsIfHasScramCredential(user, userConfigs, true)
+ addToResultsIfHasScramCredential(user, userConfigs, explicitUser =
true)
} catch {
case e: Exception => {
Review Comment:
ough >500 is too much. Well they will get cleanup as we move more scala to
java :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
