OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576375031
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -2192,8 +2192,8 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
@ValueSource(strings = Array("zk", "kraft"))
def testLongTopicNames(quorum: String): Unit = {
val client = Admin.create(createConfig)
- val longTopicName = String.join("", Collections.nCopies(249, "x"));
- val invalidTopicName = String.join("", Collections.nCopies(250, "x"));
+ val longTopicName = String.join("", Collections.nCopies(249, "x"))
Review Comment:
Small scala suggestion here (which feel free to ignore) we can use
`List.fill(249)("x").mkString("")` instead of Java `String.join` and
`Collections.nCopies`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
