chia7712 commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576457731
##########
core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala:
##########
@@ -29,9 +29,9 @@ import scala.jdk.CollectionConverters._
*/
class LinuxIoMetricsCollector(procRoot: String, val time: Time, val logger:
Logger) {
import LinuxIoMetricsCollector._
- var lastUpdateMs: Long = -1L
- var cachedReadBytes:Long = 0L
- var cachedWriteBytes:Long = 0L
+ private var lastUpdateMs: Long = -1L
Review Comment:
It seems the type declaration is unnecessary since its literal ends with `L`
##########
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##########
@@ -347,7 +347,7 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
if (isKRaftTest()) {
val result = new util.HashMap[Uuid, String]()
controllerServer.controller.findAllTopicIds(ANONYMOUS_CONTEXT).get().entrySet().forEach
{
Review Comment:
how about
`controllerServer.controller.findAllTopicIds(ANONYMOUS_CONTEXT).get().forEach((k,
v) => result.put(v, k))`
##########
core/src/main/scala/kafka/server/SharedServer.scala:
##########
@@ -107,16 +107,16 @@ class SharedServer(
@volatile var brokerMetrics: BrokerServerMetrics = _
@volatile var controllerServerMetrics: ControllerMetadataMetrics = _
@volatile var loader: MetadataLoader = _
- val snapshotsDisabledReason = new AtomicReference[String](null)
+ private val snapshotsDisabledReason = new AtomicReference[String](null)
@volatile var snapshotEmitter: SnapshotEmitter = _
- @volatile var snapshotGenerator: SnapshotGenerator = _
- @volatile var metadataLoaderMetrics: MetadataLoaderMetrics = _
+ @volatile private var snapshotGenerator: SnapshotGenerator = _
+ @volatile private var metadataLoaderMetrics: MetadataLoaderMetrics = _
def clusterId: String = metaPropsEnsemble.clusterId().get()
- def nodeId: Int = metaPropsEnsemble.nodeId().getAsInt()
+ def nodeId: Int = metaPropsEnsemble.nodeId().getAsInt
- def isUsed(): Boolean = synchronized {
+ private def isUsed(): Boolean = synchronized {
Review Comment:
How about `isUsed`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
