showuon commented on PR #15773: URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073966870
> I think deletionTask must be executed. From LogManager#startup to LogManager#startupWithConfigOverrides is not asynchronous code, so deletionTask must be put into scheduler queue. During scheduler shutdown, new tasks can not join, but previous task will be executed. Yes, you're right. It'll be enqueued anyway. > If we want to use taskRunning to check whether deletionTask is executed, we may need a new value in LogManager class to keep scheduler future object. WDYT? I think that makes sense. Or alternatively, we can add another test to test the `deleteLogs` method that it should not be blocked if `fileDeleteDelayMs=0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
