showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2073971106
>
If we want to use taskRunning to check whether deletionTask is executed,
we may need a new value in LogManager class to keep scheduler future object.
WDYT?
> I think that makes sense. Or alternatively, we can add another test to
test the deleteLogs method that it should not be blocked if fileDeleteDelayMs=0.
Sorry, I was wrong. I was checking the
`ScheduledThreadPoolExecutor#shutdown`, it'll wait until all the tasks in queue
to be completed. So as long as we are sure the task is being in queue, I think
we don't need further verification anymore. That said, no other modification is
needed. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
