jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586860365
##########
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java:
##########
@@ -213,20 +213,21 @@ private void completeCurrentBatch() {
*
* @param valueCreator a function that uses the passed buffer to create
the control
* batch that will be appended. The memory records returned must
contain one
- * control batch and that control batch have one record.
+ * control batch and that control batch have at least one record.
*/
- private void appendControlMessage(Function<ByteBuffer, MemoryRecords>
valueCreator) {
+ public void appendControlMessages(Function<ByteBuffer, CreatedRecords>
valueCreator) {
Review Comment:
Okay, I was trying to avoid decoding the `MemoryRecords`. if we are going to
read the first batch, we don't even need `CreatedRecords`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
