jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586861717


##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -159,67 +165,76 @@ public class KafkaRaftClient<T> implements RaftClient<T> {
     private final MemoryPool memoryPool;
     private final RaftMessageQueue messageQueue;
     private final QuorumConfig quorumConfig;
-    private final KafkaRaftMetrics kafkaRaftMetrics;
-    private final QuorumState quorum;
-    private final RequestManager requestManager;
     private final RaftMetadataLogCleanerManager snapshotCleaner;
 
     private final Map<Listener<T>, ListenerContext> listenerContexts = new 
IdentityHashMap<>();
     private final ConcurrentLinkedQueue<Registration<T>> pendingRegistrations 
= new ConcurrentLinkedQueue<>();
 
+    // These components need to be initialized by the method initialize() 
because they depend on the voter set
+    /*
+     * The key invariant for the kraft control record state machine is that it 
has always read to the LEO. This is achived by:

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to