Did I misunderstand Marks's comments about MSVC? I though he said that pkg-config would not be available to KiCad at runtime and that it would be available (I'm assuming via vcpkg) at build time. I really want to avoid a separate solution for MSVC if possible.
On 3/23/21 11:32 AM, Jon Evans wrote: > As Wayne points out, compatibility with older ngspice versions needs to > be considered, as well as Windows/vcpkg. > > Since pkg-config apparently can't be used in the MSVC/vcpkg environment > during the kicad build, the only option I can think of is to generate a > version header as part of the ngspice vcpkg port itself. > > So, there would be two different paths, one for Windows/MSVC and one for > other platforms. > > -Jon > > On Tue, Mar 23, 2021 at 11:28 AM Jonatan Liljedahl <li...@kymatica.com > <mailto:li...@kymatica.com>> wrote: > > Ah, yes that sounds reasonable. I guess > /CMakeModules/Findngspice.cmake could be modified to use pkg-config to > get the version and paths needed? > > On Tue, Mar 23, 2021 at 4:20 PM Jon Evans <j...@craftyjon.com > <mailto:j...@craftyjon.com>> wrote: > > > > It sounds like the preference is to move away from using a > config.h at all, which means all the KiCad packaging systems would > need to update to use pkg-config to generate a header which can then > be included in kicad's build process. Is that correct? > > > > On Tue, Mar 23, 2021 at 11:15 AM Jonatan Liljedahl > <li...@kymatica.com <mailto:li...@kymatica.com>> wrote: > >> > >> If ngspice-35 is not ready to be tagged soon, perhaps Holger could > >> make a branch called "ngspice-34-config-fix" or something, based on > >> the ngspice-34 tag but only adding the simple fix of installing > >> config.h into /include/ngspice/ instead? Then KiCad packagers could > >> build from this branch? Unless some packages are not using locally > >> built ngspice? Just some ideas of possible solutions... > >> > >> Cheers > >> > >> On Tue, Mar 23, 2021 at 3:22 PM Holger Vogt > <holger.v...@uni-due.de <mailto:holger.v...@uni-due.de>> wrote: > >> > > >> > The intention is to not at all install config.h. > >> > > >> > Installing it into ./include was a bug in ngspice-34 which has > already > >> > been removed in the current ngspice master branch. > >> > > >> > Perhaps you may make use of this bug by automatically moving > config.h > >> > from <...>/include/ to <...>/include/ngspice/ when building KiCad, > >> > before we will have a solution without config.h in ngspice-35? > >> > > >> > > >> > _______________________________________________ > >> > Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > >> > Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > >> > Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > >> > More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > >> > >> > >> > >> -- > >> /Jonatan > >> http://kymatica.com <http://kymatica.com> > >> > >> _______________________________________________ > >> Mailing list: https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > >> Post to : kicad-developers@lists.launchpad.net > <mailto:kicad-developers@lists.launchpad.net> > >> Unsubscribe : https://launchpad.net/~kicad-developers > <https://launchpad.net/~kicad-developers> > >> More help : https://help.launchpad.net/ListHelp > <https://help.launchpad.net/ListHelp> > > > > -- > /Jonatan > http://kymatica.com <http://kymatica.com> > > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
