vcl/osx/a11yvaluewrapper.mm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit bbb8cbcd404e608f6016a812d47170080a4671a6
Author: Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Thu Nov 12 14:19:19 2020 +0100
Commit: Stephan Bergmann <sberg...@redhat.com>
CommitDate: Sun Nov 15 17:17:58 2020 +0100
Assumed UNOIDL long vs. C++ sal_Int32 confusion
UNOIDL css.accessibility.XAccessibleValue.getCurrentValue returning any is
documented: "The exact return type is implementation dependent. Typical
types
are long and double." So assume that this code meant to extract a UNOIDL
long,
i.e., sal_Int32 in C++, value. (And similarly for getMinimum/MaximumValue.
Also, the "TODO: Detect Type from Any" comments seem to imply that something
more elaborate is asked for, anyway?)
Change-Id: If01956eaf4ec186931414a4e1d55429e66901c55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105745
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
diff --git a/vcl/osx/a11yvaluewrapper.mm b/vcl/osx/a11yvaluewrapper.mm
index 4882cd2eff97..0cf3786fbe6e 100644
--- a/vcl/osx/a11yvaluewrapper.mm
+++ b/vcl/osx/a11yvaluewrapper.mm
@@ -31,7 +31,7 @@ using namespace ::com::sun::star::uno;
+(id)valueAttributeForElement:(AquaA11yWrapper *)wrapper {
// TODO: Detect Type from Any
if ( [ wrapper accessibleValue ] ) {
- long value = 0;
+ sal_Int32 value = 0;
[ wrapper accessibleValue ] -> getCurrentValue() >>= value;
return [ NSNumber numberWithLong: value ];
}
@@ -41,7 +41,7 @@ using namespace ::com::sun::star::uno;
+(id)minValueAttributeForElement:(AquaA11yWrapper *)wrapper {
// TODO: Detect Type from Any
if ( [ wrapper accessibleValue ] ) {
- long value = 0;
+ sal_Int32 value = 0;
[ wrapper accessibleValue ] -> getMinimumValue() >>= value;
return [ NSNumber numberWithLong: value ];
}
@@ -51,7 +51,7 @@ using namespace ::com::sun::star::uno;
+(id)maxValueAttributeForElement:(AquaA11yWrapper *)wrapper {
// TODO: Detect Type from Any
if ( [ wrapper accessibleValue ] ) {
- long value = 0;
+ sal_Int32 value = 0;
[ wrapper accessibleValue ] -> getMaximumValue() >>= value;
return [ NSNumber numberWithLong: value ];
}
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
