On 4/8/24 16:39, Frode Nordahl wrote:
> The vlog - Python3 test makes use of output from Python
> Tracebacks in its assertion.
> 
> In Python 3.12 a line with tophat (``^``) markers is added below
> the assert line, which makes the test fail.

Hmm.  Are you sure it's 3.12?

I believe I did run tests with 3.12 a few times at some point
and didn't have this issue.

Bets regards, Ilya Maximets.

> 
> Strip lines starting whith whitespace and otherwise only
> containing one or more occurence of the ``^`` character from the
> output before performing the test assertions.
> 
> Note that the extra pair of brackets (``[]``) is required to make
> m4 pass the expected string (``[[:space:]]``) to sed.
> 
> Reported-at: https://launchpad.net/bugs/2060434
> Signed-off-by: Frode Nordahl <fnord...@ubuntu.com>
> ---
>  tests/vlog.at | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/vlog.at b/tests/vlog.at
> index 785014956..9a0c7d787 100644
> --- a/tests/vlog.at
> +++ b/tests/vlog.at
> @@ -8,6 +8,7 @@ AT_CHECK([$PYTHON3 $srcdir/test-vlog.py --log-file log_file \
>  
>  AT_CHECK([sed -e 's/.*-.*-.*T..:..:..Z |//' \
>  -e 's/File ".*", line [[0-9]][[0-9]]*,/File <name>, line <number>,/' \
> +-e '/[[[:space:]]]\+^\+/d' \
>  stderr_log], [0], [dnl
>    0  | module_0 | EMER | emergency
>    1  | module_0 | ERR | error

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to