On Mon, Apr 8, 2024 at 9:18 PM Frode Nordahl <fnord...@ubuntu.com> wrote: > > On Mon, Apr 8, 2024 at 9:14 PM Ilya Maximets <i.maxim...@ovn.org> wrote: > > > > On 4/8/24 16:48, Frode Nordahl wrote: > > > On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets <i.maxim...@ovn.org> wrote: > > >> > > >> On 4/8/24 16:39, Frode Nordahl wrote: > > >>> The vlog - Python3 test makes use of output from Python > > >>> Tracebacks in its assertion. > > >>> > > >>> In Python 3.12 a line with tophat (``^``) markers is added below > > >>> the assert line, which makes the test fail. > > >> > > >> Hmm. Are you sure it's 3.12? > > >> > > >> I believe I did run tests with 3.12 a few times at some point > > >> and didn't have this issue. > > > > > > I guess I should have spelled out the specific point release in use, > > > we see it in Ubuntu with Python 3.12.2 [0]. > > > > > > 0: https://launchpad.net/ubuntu/+source/python3.12/3.12.2-5ubuntu3 > > > > > > > Even 3.12.2 doesn't seem to explain the situation. > > > > 3.12.2 in Fedora 41 doesn't have this issue. Moreover, these is something > > fishy here. On Fedora I don't have any '^' markers in the output, but on > > Ubuntu I see them. AFAICT, recent changes in 3.12 branch should have > > changed > > the underlining from a single '^' to multiple. But not from having none at > > all to multiple. Also, the same should be true for python starting from > > 3.10: > > https://github.com/python/cpython/issues/116563 > > That's strange. > > > > To be clear, I'm not opposed to a change, I'm just a little puzzled on what > > is going on here, as it doesn't seem to be related much to the python > > version. > > Thanks for checking, and no issue at all, I was also a bit confused as > it appeared to change between two package patch versions, and I landed > on something Python 3.12.2 to be most likely. > > I'll do an extra round of due diligence so that we are sure we > understand what's going on.
I've tracked the change of behavior down to this upstream fix: https://github.com/python/cpython/issues/116034 Which is included in the Debian/Ubuntu packages. AFAICT from the discussion on that issue, they are essentially making Python 3.11 and 3.12 behave like Python 3.13. So, I guess for OVS, we could make the commit subject address Python 3.13 compatibility with a note about those backports for 3.12 and 3.11 in the message? WDYT? > -- > Frode Nordahl > > > Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
