On Fri, Dec 23, 2022 at 1:22 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Ted Yu <yuzhih...@gmail.com> writes: > > In makeItemLikeRegex : > > > + /* See regexp.c for explanation */ > > + CHECK_FOR_INTERRUPTS(); > > + pg_regerror(re_result, &re_tmp, errMsg, > > sizeof(errMsg)); > > + ereturn(escontext, false, > > > Since an error is returned, I wonder if the `CHECK_FOR_INTERRUPTS` call > is > > still necessary. > > Yes, it is. We don't want a query-cancel transformed into a soft error. > > regards, tom lane > Hi, For this case (`invalid regular expression`), the potential user interruption is one reason for stopping execution. I feel surfacing user interruption somehow masks the underlying error.
The same regex, without user interruption, would exhibit an `invalid regular expression` error. I think it would be better to surface the error. Cheers
