Hi, On 2023-01-20 12:09:05 -0500, Tom Lane wrote: > Jelte Fennema <postg...@jeltef.nl> writes: > > To me a master branch that pgindent never complains about sounds > > amazing! And I personally think rejection of unindented pushes and > > cfbot complaining about unindented patches would be a very good thing, > > because that seems to be the only solution that could achieve that. > > The core problem here is that requiring that would translate to > requiring every code contributor to have a working copy of pg_bsd_indent.
Wouldn't just every committer suffice? > Maybe that's not a huge lift, but it'd be YA obstacle to new contributors, > and we don't need any more of those. > > Yeah, if we switched to some other tool maybe we could reduce the size > of that problem. But as Bruce replied, we've not found another one that > (a) can be coaxed to make output comparable to what we're accustomed to > and (b) seems decently well maintained. One question around this is how much change we'd accept. clang-format for example is well maintained and can get somewhat close to our style - but there are things that can't easily be approximated. Greetings, Andres Freund
