On Thu, 19 Jan 2023 at 13:02, Isaac Morland <isaac.morl...@gmail.com> wrote:
> On Thu, 19 Jan 2023 at 11:30, Justin Pryzby <pry...@telsasoft.com> wrote: > >> On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote: >> > >> > I thought I had: https://commitfest.postgresql.org/42/4133/ >> >> This is failing tests: >> http://cfbot.cputube.org/isaac-morland.html >> >> It seems like any "make check" would fail .. but did you also try >> cirrusci from your own github account? >> ./src/tools/ci/README >> > > I definitely ran "make check" but I did not realize there is also > cirrusci. I will look at that. I'm having trouble interpreting the cfbot > page to which you linked but I'll try to run cirrusci myself before > worrying too much about that. > > Running "make check" the first time I was surprised to see no failures - > so I added tests for \df+, which passed when I did "make check". > >> It turns out that my tests wanted the owner to be “vagrant” rather than “postgres”. This is apparently because I was running as that user (in a Vagrant VM) when running the tests. Then I took that output and just made it the expected output. I’ve re-worked my build environment a bit so that I run as “postgres” inside the Vagrant VM. What I don’t understand is why that didn’t break all the other tests. I would have expected “postgres” to show up all over the expected results and be changed to “vagrant” by what I did; so I should have seen all sorts of test failures in the existing tests. Anyway, my new tests now have the proper value in the Owner column so let’s see what CI does with it. BTW, I think "ELSE NULL" could be omitted. >> > > Looks like; I'll update. Might as well reduce the visual size of the code. > I did this. I’m ambivalent about this because I usually think of CASE and similar constructs as needing to explicitly cover all possible cases but the language does provide for the NULL default case so may as well use the feature where applicable.
0001-Remove-source-code-display-from-df-v3.patch
Description: Binary data
