On Sun, Jan 22, 2023 at 12:18:34AM -0500, Isaac Morland wrote: > On Thu, 19 Jan 2023 at 13:02, Isaac Morland <isaac.morl...@gmail.com> wrote: > > On Thu, 19 Jan 2023 at 11:30, Justin Pryzby <pry...@telsasoft.com> wrote: > >> On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote: > >> > > >> > I thought I had: https://commitfest.postgresql.org/42/4133/ > >> > >> This is failing tests: > >> http://cfbot.cputube.org/isaac-morland.html > >> > >> It seems like any "make check" would fail .. but did you also try > >> cirrusci from your own github account? > >> ./src/tools/ci/README > > > > I definitely ran "make check" but I did not realize there is also > > cirrusci. I will look at that. I'm having trouble interpreting the cfbot > > page to which you linked but I'll try to run cirrusci myself before > > worrying too much about that. > > > > Running "make check" the first time I was surprised to see no failures - > > so I added tests for \df+, which passed when I did "make check". > > > It turns out that my tests wanted the owner to be “vagrant” rather than > “postgres”. This is apparently because I was running as that user (in a > Vagrant VM) when running the tests. Then I took that output and just made > it the expected output. I’ve re-worked my build environment a bit so that I > run as “postgres” inside the Vagrant VM. > > What I don’t understand is why that didn’t break all the other tests.
Probably because the other tests avoid showing the owner, exactly because it varies depending on who runs the tests. Most of the "plus" commands aren't tested, at least in the sql regression tests. We should probably change one of the CI usernames to something other than "postgres" to catch the case that someone hardcodes "postgres". > proper value in the Owner column so let’s see what CI does with it. Or better: see above about using it from your github account. -- Justin
